This change is 

[APPROVALNOTIFIER] This PR is NOT APPROVED

Needs approval from an approver in each of these OWNERS Files:

• pkg/OWNERS
• translations/kubectl/OWNERS

We suggest the following people:
cc @brendandburns
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-bot unit test this

@k8s-bot verify test this

@k8s-bot gci gce e2e test this

self-lgtm on approve from @smarterclayton

Review status: 0 of 23 files reviewed at latest revision, 52 unresolved discussions.

pkg/kubectl/cmd/annotate.go, line 135 at r1 (raw file):

e namespace of the specified resource types")
cmd.Flags().String("resource-version", "", i18n.T("If non-empty, the annotation update will only succeed if this is the current resource-version for the object. Only valid when specifying a single resource.)"))
Looks like too many brackets to me

pkg/kubectl/cmd/autoscale.go, line 67 at r1 (raw file):

	}
	cmdutil.AddPrinterFlags(cmd)
	cmd.Flags().String("generator", "horizontalpodautoscaler/v1", i18n.T("The name of the API generator to use. Currently there is only 1 generator.)"))

Too many brackets?

pkg/kubectl/cmd/autoscale.go, line 72 at r1 (raw file):

	cmd.MarkFlagRequired("max")
	cmd.Flags().Int("cpu-percent", -1, fmt.Sprintf("The target average CPU utilization (represented as a percent of requested CPU) over all the pods. If it's not specified or negative, a default autoscaling policy will be used."))
	cmd.Flags().String("name", "", i18n.T("The name for the newly created object. If not specified, the name of the input resource will be used.)"))

Same, too many brackets?

pkg/kubectl/cmd/clusterinfo_dump.go, line 46 at r1 (raw file):

		},
	}
	cmd.Flags().String("output-directory", "", i18n.T("Where to output the files.  If empty or '-' uses stdout, otherwise creates a directory hierarchy in that directory)"))

Same?

pkg/kubectl/cmd/create_clusterrolebinding.go, line 56 at r1 (raw file):

	cmdutil.AddPrinterFlags(cmd)
	cmdutil.AddGeneratorFlags(cmd, cmdutil.ClusterRoleBindingV1GeneratorName)
	cmd.Flags().String("clusterrole", "", i18n.T("ClusterRole this ClusterRoleBinding should reference)"))

Same.

pkg/kubectl/cmd/create_pdb.go, line 63 at r1 (raw file):

	cmdutil.AddPrinterFlags(cmd)
	cmdutil.AddGeneratorFlags(cmd, cmdutil.PodDisruptionBudgetV1GeneratorName)
	cmd.Flags().String("min-available", "1", i18n.T("The minimum number or percentage of available pods this budget requires.)"))

Same

pkg/kubectl/cmd/create_pdb.go, line 64 at r1 (raw file):

	cmdutil.AddGeneratorFlags(cmd, cmdutil.PodDisruptionBudgetV1GeneratorName)
	cmd.Flags().String("min-available", "1", i18n.T("The minimum number or percentage of available pods this budget requires.)"))
	cmd.Flags().String("selector", "", i18n.T("A label selector to use for this budget. Only equality-based selector requirements are supported.)"))

Same

pkg/kubectl/cmd/create_quota.go, line 61 at r1 (raw file):

	cmdutil.AddPrinterFlags(cmd)
	cmdutil.AddGeneratorFlags(cmd, cmdutil.ResourceQuotaV1GeneratorName)
	cmd.Flags().String("hard", "", i18n.T("A comma-delimited set of resource=quantity pairs that define a hard limit.)"))

Same

pkg/kubectl/cmd/create_quota.go, line 62 at r1 (raw file):

	cmdutil.AddGeneratorFlags(cmd, cmdutil.ResourceQuotaV1GeneratorName)
	cmd.Flags().String("hard", "", i18n.T("A comma-delimited set of resource=quantity pairs that define a hard limit.)"))
	cmd.Flags().String("scopes", "", i18n.T("A comma-delimited set of quota scopes that must all match each object tracked by the quota.)"))

Same

pkg/kubectl/cmd/create_rolebinding.go, line 56 at r1 (raw file):

	cmdutil.AddPrinterFlags(cmd)
	cmdutil.AddGeneratorFlags(cmd, cmdutil.RoleBindingV1GeneratorName)
	cmd.Flags().String("clusterrole", "", i18n.T("ClusterRole this RoleBinding should reference)"))

Brackets problem

pkg/kubectl/cmd/create_rolebinding.go, line 57 at r1 (raw file):

	cmdutil.AddGeneratorFlags(cmd, cmdutil.RoleBindingV1GeneratorName)
	cmd.Flags().String("clusterrole", "", i18n.T("ClusterRole this RoleBinding should reference)"))
	cmd.Flags().String("role", "", i18n.T("Role this RoleBinding should reference)"))

Brackets problem

pkg/kubectl/cmd/create_secret.go, line 88 at r1 (raw file):

	cmd.Flags().StringSlice("from-file", []string{}, "Key files can be specified using their file path, in which case a default name will be given to them, or optionally with a name and file path, in which case the given name will be used.  Specifying a directory will iterate each named file in the directory that is a valid secret key.")
	cmd.Flags().StringArray("from-literal", []string{}, "Specify a key and literal value to insert in secret (i.e. mykey=somevalue)")
	cmd.Flags().String("type", "", i18n.T("The type of secret to create)"))

Brackets problem

pkg/kubectl/cmd/create_secret.go, line 156 at r1 (raw file):

	cmdutil.AddPrinterFlags(cmd)
	cmdutil.AddGeneratorFlags(cmd, cmdutil.SecretForDockerRegistryV1GeneratorName)
	cmd.Flags().String("docker-username", "", i18n.T("Username for Docker registry authentication)"))

Brackets problem

pkg/kubectl/cmd/create_secret.go, line 158 at r1 (raw file):

	cmd.Flags().String("docker-username", "", i18n.T("Username for Docker registry authentication)"))
	cmd.MarkFlagRequired("docker-username")
	cmd.Flags().String("docker-password", "", i18n.T("Password for Docker registry authentication)"))

Brackets problem

pkg/kubectl/cmd/create_secret.go, line 160 at r1 (raw file):

	cmd.Flags().String("docker-password", "", i18n.T("Password for Docker registry authentication)"))
	cmd.MarkFlagRequired("docker-password")
	cmd.Flags().String("docker-email", "", i18n.T("Email for Docker registry)"))

Brackets problem

pkg/kubectl/cmd/create_secret.go, line 162 at r1 (raw file):

	cmd.Flags().String("docker-email", "", i18n.T("Email for Docker registry)"))
	cmd.MarkFlagRequired("docker-email")
	cmd.Flags().String("docker-server", "https://index.docker.io/v1/", i18n.T("Server location for Docker registry)"))

Brackets problem

pkg/kubectl/cmd/create_secret.go, line 227 at r1 (raw file):

	cmdutil.AddPrinterFlags(cmd)
	cmdutil.AddGeneratorFlags(cmd, cmdutil.SecretForTLSV1GeneratorName)
	cmd.Flags().String("cert", "", i18n.T("Path to PEM encoded public key certificate.)"))

Brackets problem

pkg/kubectl/cmd/create_secret.go, line 228 at r1 (raw file):

	cmdutil.AddGeneratorFlags(cmd, cmdutil.SecretForTLSV1GeneratorName)
	cmd.Flags().String("cert", "", i18n.T("Path to PEM encoded public key certificate.)"))
	cmd.Flags().String("key", "", i18n.T("Path to private key associated with given certificate.)"))

Brackets problem

pkg/kubectl/cmd/create_service.go, line 82 at r1 (raw file):

	cmdutil.AddGeneratorFlags(cmd, cmdutil.ServiceClusterIPGeneratorV1Name)
	addPortFlags(cmd)
	cmd.Flags().String("clusterip", "", i18n.T("Assign your own ClusterIP or set to 'None' for a 'headless' service (no loadbalancing).)"))

Brackets problem

pkg/kubectl/cmd/create_service.go, line 254 at r1 (raw file):

	cmdutil.AddGeneratorFlags(cmd, cmdutil.ServiceExternalNameGeneratorV1Name)
	addPortFlags(cmd)
	cmd.Flags().String("external-name", "", i18n.T("external name of service)"))

Brackets problem

pkg/kubectl/cmd/edit.go, line 115 at r1 (raw file):

	cmdutil.AddValidateFlags(cmd)
	cmd.Flags().StringP("output", "o", "yaml", "Output format. One of: yaml|json.")
	cmd.Flags().String("output-version", "", i18n.T("Output the formatted object with the given group version (for ex: 'extensions/v1beta1').)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 99 at r1 (raw file):

	}
	cmdutil.AddPrinterFlags(cmd)
	cmd.Flags().String("generator", "service/v2", i18n.T("The name of the API generator to use. There are 2 generators: 'service/v1' and 'service/v2'. The only difference between them is that service port in v1 is named 'default', while it is left unnamed in v2. Default is 'service/v2'.)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 100 at r1 (raw file):

	cmdutil.AddPrinterFlags(cmd)
	cmd.Flags().String("generator", "service/v2", i18n.T("The name of the API generator to use. There are 2 generators: 'service/v1' and 'service/v2'. The only difference between them is that service port in v1 is named 'default', while it is left unnamed in v2. Default is 'service/v2'.)"))
	cmd.Flags().String("protocol", "", i18n.T("The network protocol for the service to be created. Default is 'TCP'.)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 101 at r1 (raw file):

	cmd.Flags().String("generator", "service/v2", i18n.T("The name of the API generator to use. There are 2 generators: 'service/v1' and 'service/v2'. The only difference between them is that service port in v1 is named 'default', while it is left unnamed in v2. Default is 'service/v2'.)"))
	cmd.Flags().String("protocol", "", i18n.T("The network protocol for the service to be created. Default is 'TCP'.)"))
	cmd.Flags().String("port", "", i18n.T("The port that the service should serve on. Copied from the resource being exposed, if unspecified)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 102 at r1 (raw file):

	cmd.Flags().String("protocol", "", i18n.T("The network protocol for the service to be created. Default is 'TCP'.)"))
	cmd.Flags().String("port", "", i18n.T("The port that the service should serve on. Copied from the resource being exposed, if unspecified)"))
	cmd.Flags().String("type", "", i18n.T("Type for this service: ClusterIP, NodePort, or LoadBalancer. Default is 'ClusterIP'.)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 106 at r1 (raw file):

	cmd.Flags().Bool("create-external-load-balancer", false, "If true, create an external load balancer for this service (trumped by --type). Implementation is cloud provider dependent. Default is 'false'.")
	cmd.Flags().MarkDeprecated("create-external-load-balancer", "use --type=\"LoadBalancer\" instead")
	cmd.Flags().String("load-balancer-ip", "", i18n.T("IP to assign to the Load Balancer. If empty, an ephemeral IP will be created and used (cloud-provider specific).)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 107 at r1 (raw file):

	cmd.Flags().MarkDeprecated("create-external-load-balancer", "use --type=\"LoadBalancer\" instead")
	cmd.Flags().String("load-balancer-ip", "", i18n.T("IP to assign to the Load Balancer. If empty, an ephemeral IP will be created and used (cloud-provider specific).)"))
	cmd.Flags().String("selector", "", i18n.T("A label selector to use for this service. Only equality-based selector requirements are supported. If empty (the default) infer the selector from the replication controller or replica set.)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 109 at r1 (raw file):

	cmd.Flags().String("selector", "", i18n.T("A label selector to use for this service. Only equality-based selector requirements are supported. If empty (the default) infer the selector from the replication controller or replica set.)"))
	cmd.Flags().StringP("labels", "l", "", "Labels to apply to the service created by this call.")
	cmd.Flags().String("container-port", "", i18n.T("Synonym for --target-port)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 111 at r1 (raw file):

	cmd.Flags().String("container-port", "", i18n.T("Synonym for --target-port)"))
	cmd.Flags().MarkDeprecated("container-port", "--container-port will be removed in the future, please use --target-port instead")
	cmd.Flags().String("target-port", "", i18n.T("Name or number for the port on the container that the service should direct traffic to. Optional.)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 112 at r1 (raw file):

	cmd.Flags().MarkDeprecated("container-port", "--container-port will be removed in the future, please use --target-port instead")
	cmd.Flags().String("target-port", "", i18n.T("Name or number for the port on the container that the service should direct traffic to. Optional.)"))
	cmd.Flags().String("external-ip", "", i18n.T("Additional external IP address (not managed by Kubernetes) to accept for the service. If this IP is routed to a node, the service can be accessed by this IP in addition to its generated service IP.)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 113 at r1 (raw file):

	cmd.Flags().String("target-port", "", i18n.T("Name or number for the port on the container that the service should direct traffic to. Optional.)"))
	cmd.Flags().String("external-ip", "", i18n.T("Additional external IP address (not managed by Kubernetes) to accept for the service. If this IP is routed to a node, the service can be accessed by this IP in addition to its generated service IP.)"))
	cmd.Flags().String("overrides", "", i18n.T("An inline JSON override for the generated object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field.)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 114 at r1 (raw file):

	cmd.Flags().String("external-ip", "", i18n.T("Additional external IP address (not managed by Kubernetes) to accept for the service. If this IP is routed to a node, the service can be accessed by this IP in addition to its generated service IP.)"))
	cmd.Flags().String("overrides", "", i18n.T("An inline JSON override for the generated object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field.)"))
	cmd.Flags().String("name", "", i18n.T("The name for the newly created object.)"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 115 at r1 (raw file):

	cmd.Flags().String("overrides", "", i18n.T("An inline JSON override for the generated object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field.)"))
	cmd.Flags().String("name", "", i18n.T("The name for the newly created object.)"))
	cmd.Flags().String("session-affinity", "", i18n.T("If non-empty, set the session affinity for the service to this; legal values: 'None', 'ClientIP')"))

Brackets problem

pkg/kubectl/cmd/expose.go, line 116 at r1 (raw file):

	cmd.Flags().String("name", "", i18n.T("The name for the newly created object.)"))
	cmd.Flags().String("session-affinity", "", i18n.T("If non-empty, set the session affinity for the service to this; legal values: 'None', 'ClientIP')"))
	cmd.Flags().String("cluster-ip", "", i18n.T("ClusterIP to be assigned to the service. Leave empty to auto-allocate, or set to 'None' to create a headless service.)"))

Brackets problem

pkg/kubectl/cmd/logs.go, line 109 at r1 (raw file):

	cmd.Flags().BoolP("previous", "p", false, "If true, print the logs for the previous instance of the container in a pod if it exists.")
	cmd.Flags().Int64("tail", -1, "Lines of recent log file to display. Defaults to -1 with no selector, showing all log lines otherwise 10, if a selector is provided.")
	cmd.Flags().String("since-time", "", i18n.T("Only return logs after a specific date (RFC3339). Defaults to all logs. Only one of since-time / since may be used.)"))

Brackets problem

pkg/kubectl/cmd/rollingupdate.go, line 100 at r1 (raw file):

	cmd.MarkFlagRequired("filename")
	cmd.Flags().String("image", "", i18n.T("Image to use for upgrading the replication controller. Must be distinct from the existing image (either new image or new image tag).  Can not be used with --filename/-f)"))
	cmd.MarkFlagRequired("image")

Brackets problem

pkg/kubectl/cmd/rollingupdate.go, line 101 at r1 (raw file):

	cmd.Flags().String("image", "", i18n.T("Image to use for upgrading the replication controller. Must be distinct from the existing image (either new image or new image tag).  Can not be used with --filename/-f)"))
	cmd.MarkFlagRequired("image")
	cmd.Flags().String("deployment-label-key", "deployment", i18n.T("The key to use to differentiate between two different controllers, default 'deployment'.  Only relevant when --image is specified, ignored otherwise)"))

Brackets problem

pkg/kubectl/cmd/rollingupdate.go, line 102 at r1 (raw file):

	cmd.MarkFlagRequired("image")
	cmd.Flags().String("deployment-label-key", "deployment", i18n.T("The key to use to differentiate between two different controllers, default 'deployment'.  Only relevant when --image is specified, ignored otherwise)"))
	cmd.Flags().String("container", "", i18n.T("Container name which will have its image upgraded. Only relevant when --image is specified, ignored otherwise. Required when using --image on a multi-container pod)"))

Brackets problem

pkg/kubectl/cmd/rollingupdate.go, line 103 at r1 (raw file):

	cmd.Flags().String("deployment-label-key", "deployment", i18n.T("The key to use to differentiate between two different controllers, default 'deployment'.  Only relevant when --image is specified, ignored otherwise)"))
	cmd.Flags().String("container", "", i18n.T("Container name which will have its image upgraded. Only relevant when --image is specified, ignored otherwise. Required when using --image on a multi-container pod)"))
	cmd.Flags().String("image-pull-policy", "", i18n.T("Explicit policy for when to pull container images. Required when --image is same as existing image, ignored otherwise.)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 114 at r1 (raw file):

func addRunFlags(cmd *cobra.Command) {
	cmdutil.AddDryRunFlag(cmd)
	cmd.Flags().String("generator", "", i18n.T("The name of the API generator to use, see http://kubernetes.io/docs/user-guide/kubectl-conventions/#generators for a list.)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 115 at r1 (raw file):

	cmdutil.AddDryRunFlag(cmd)
	cmd.Flags().String("generator", "", i18n.T("The name of the API generator to use, see http://kubernetes.io/docs/user-guide/kubectl-conventions/#generators for a list.)"))
	cmd.Flags().String("image", "", i18n.T("The image for the container to run.)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 117 at r1 (raw file):

	cmd.Flags().String("image", "", i18n.T("The image for the container to run.)"))
	cmd.MarkFlagRequired("image")
	cmd.Flags().String("image-pull-policy", "", i18n.T("The image pull policy for the container. If left empty, this value will not be specified by the client and defaulted by the server)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 120 at r1 (raw file):

	cmd.Flags().IntP("replicas", "r", 1, "Number of replicas to create for this container. Default is 1.")
	cmd.Flags().Bool("rm", false, "If true, delete resources created in this command for attached containers.")
	cmd.Flags().String("overrides", "", i18n.T("An inline JSON override for the generated object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field.)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 122 at r1 (raw file):

	cmd.Flags().String("overrides", "", i18n.T("An inline JSON override for the generated object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field.)"))
	cmd.Flags().StringSlice("env", []string{}, "Environment variables to set in the container")
	cmd.Flags().String("port", "", i18n.T("The port that this container exposes.  If --expose is true, this is also the port used by the service that is created.)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 129 at r1 (raw file):

	cmd.Flags().Bool("attach", false, "If true, wait for the Pod to start running, and then attach to the Pod as if 'kubectl attach ...' were called.  Default false, unless '-i/--stdin' is set, in which case the default is true. With '--restart=Never' the exit code of the container process is returned.")
	cmd.Flags().Bool("leave-stdin-open", false, "If the pod is started in interactive mode or with stdin, leave stdin open after the first attach completes. By default, stdin will be closed after the first attach completes.")
	cmd.Flags().String("restart", "Always", i18n.T("The restart policy for this Pod.  Legal values [Always, OnFailure, Never].  If set to 'Always' a deployment is created, if set to 'OnFailure' a job is created, if set to 'Never', a regular pod is created. For the latter two --replicas must be 1.  Default 'Always', for CronJobs `Never`.)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 131 at r1 (raw file):

	cmd.Flags().String("restart", "Always", i18n.T("The restart policy for this Pod.  Legal values [Always, OnFailure, Never].  If set to 'Always' a deployment is created, if set to 'OnFailure' a job is created, if set to 'Never', a regular pod is created. For the latter two --replicas must be 1.  Default 'Always', for CronJobs `Never`.)"))
	cmd.Flags().Bool("command", false, "If true and extra arguments are present, use them as the 'command' field in the container, rather than the 'args' field which is the default.")
	cmd.Flags().String("requests", "", i18n.T("The resource requirement requests for this container.  For example, 'cpu=100m,memory=256Mi'.  Note that server side components may assign requests depending on the server configuration, such as limit ranges.)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 132 at r1 (raw file):

	cmd.Flags().Bool("command", false, "If true and extra arguments are present, use them as the 'command' field in the container, rather than the 'args' field which is the default.")
	cmd.Flags().String("requests", "", i18n.T("The resource requirement requests for this container.  For example, 'cpu=100m,memory=256Mi'.  Note that server side components may assign requests depending on the server configuration, such as limit ranges.)"))
	cmd.Flags().String("limits", "", i18n.T("The resource requirement limits for this container.  For example, 'cpu=200m,memory=512Mi'.  Note that server side components may assign limits depending on the server configuration, such as limit ranges.)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 134 at r1 (raw file):

	cmd.Flags().String("limits", "", i18n.T("The resource requirement limits for this container.  For example, 'cpu=200m,memory=512Mi'.  Note that server side components may assign limits depending on the server configuration, such as limit ranges.)"))
	cmd.Flags().Bool("expose", false, "If true, a public, external service is created for the container(s) which are run")
	cmd.Flags().String("service-generator", "service/v2", i18n.T("The name of the generator to use for creating a service.  Only used if --expose is true)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 135 at r1 (raw file):

	cmd.Flags().Bool("expose", false, "If true, a public, external service is created for the container(s) which are run")
	cmd.Flags().String("service-generator", "service/v2", i18n.T("The name of the generator to use for creating a service.  Only used if --expose is true)"))
	cmd.Flags().String("service-overrides", "", i18n.T("An inline JSON override for the generated service object. If this is non-empty, it is used to override the generated object. Requires that the object supply a valid apiVersion field.  Only used if --expose is true.)"))

Brackets problem

pkg/kubectl/cmd/run.go, line 138 at r1 (raw file):

	cmd.Flags().Bool("quiet", false, "If true, suppress prompt messages.")
	cmd.Flags().String("schedule", "", i18n.T("A schedule in the Cron format the job should be run with.)"))
}

Brackets problem

pkg/kubectl/cmd/run_test.go, line 84 at r1 (raw file):

	for _, test := range tests {
		cmd := &cobra.Command{}
		cmd.Flags().String("restart", "", i18n.T("dummy restart flag)"))

Brackets problem

pkg/kubectl/cmd/scale.go, line 83 at r1 (raw file):

		ArgAliases: argAliases,
	}
	cmd.Flags().String("resource-version", "", i18n.T("Precondition for resource version. Requires that the current resource version match this value in order to scale.)"))

Brackets problem

Comments from Reviewable

@ericchiang all fixed, thanks for the review! please take another look.

@brendandburns I don't see that ericchiang ever reviewed this PR ;) I will review this in 1-2 days, back from PTO

@brendandburns please rebase then I'll shepherd this.

@fabianofranz rebased, ptal.

Thanks!
--brendan

@k8s-bot bazel test this
@k8s-bot verify test this
@k8s-bot kubemark e2e test this
@k8s-bot non-cri e2e test this

/lgtm

@fabianofranz: you can't LGTM a PR unless you are an assignee.

/lgtm

/lgtm

Reviewed 22 of 23 files at r2.
Review status: all files reviewed at latest revision, 52 unresolved discussions.

Comments from Reviewable

@zen: you can't LGTM a PR unless you are an assignee.

Automatic merge from submit-queue (batch tested with PRs 38957, 41819, 41851, 40667, 41373)